React|WC Parity: Content Switcher #18815
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
requested review from
a team and
laurenmrice
and removed request for
a team
packages/web-components/src/components/content-switcher/content-switcher.ts
Outdated
Show resolved
Hide resolved
|
looks like a similar issue to before? make sure |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18815 +/- ##
=======================================
Coverage 84.88% 84.88%
=======================================
Files 396 396
Lines 14512 14512
Branches 4770 4773 +3
=======================================
Hits 12319 12319
Misses 2044 2044
Partials 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -27,16 +27,28 @@ const sizes = { | |||
| }; | |||
|
|
|||
| const args = { | |||
| value: '', | |||
| value: 'all', | |||
| size: null, | |||
| disableSelection: false, | |||
There was a problem hiding this comment.
is the disableSelection needed? it's not in reacts story
There was a problem hiding this comment.
Good question! I guess it is not needed, since there is no disableSelection in the .tsx file.
I'll remove that!
| /** | ||
| * Choose whether or not to automatically change selection on focus when left/right arrow pressed. Defaults to 'automatic' | ||
| */ | ||
| @property() |
There was a problem hiding this comment.
| @property() | |
| @property({ attribute: 'selection-mode'}) |
and should we maybe a defs file with enums for the content switcher types?
Closes #18319
Added to new props to match the React Content Switcher.
Changelog
New
SelectionModeprop added with "manual" and "automatic" values.SelectedIndexprop added to change the initial selectedIndex.Changed
onSelecttoonChangeon storybookRemoved
Testing / Reviewing