Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite wrapFocus utils in typescript #18913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #18911

Rewrote the wrapFocus utilities in TypreScript.

Changelog

New

Changed

  • Rewrote the wrapFocus utilities in TypreScript.
  • Updated types in usages of the wrapFocus utilities.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33f583c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67e2aee8cc815e000826aef3
😎 Deploy Preview https://deploy-preview-18913--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 33f583c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67e2aee878767b0008cb4ce7
😎 Deploy Preview https://deploy-preview-18913--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 33f583c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67e2aee890362a0008b9f351
😎 Deploy Preview https://deploy-preview-18913--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (8d30a69) to head (33f583c).

Files with missing lines Patch % Lines
packages/react/src/internal/FloatingMenu.tsx 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18913      +/-   ##
==========================================
+ Coverage   84.86%   84.91%   +0.04%     
==========================================
  Files         398      397       -1     
  Lines       14499    14465      -34     
  Branches     4725     4712      -13     
==========================================
- Hits        12305    12283      -22     
+ Misses       2046     2037       -9     
+ Partials      148      145       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review March 25, 2025 13:48
@adamalston adamalston requested review from a team as code owners March 25, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite wrapFocus utils in TypeScript
1 participant