Skip to content

Commit

Permalink
CNCLI: Fix hardcoded binary and bump version requirement (#1846)
Browse files Browse the repository at this point in the history
## Description
Closes #1845 (thanks @Scampicfx)
It also bumps the minimum required version to the latest (6.5.1)
released in November last year.

Co-authored-by: RdLrT <[email protected]>
  • Loading branch information
Scitz0 and rdlrt authored Jan 14, 2025
1 parent 2ecea33 commit 947f152
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/cnode-helper-scripts/cncli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ cncliInit() {
if ! mkdir -p "${TMP_DIR}" 2>/dev/null; then echo "ERROR: Failed to create directory for temporary files: ${TMP_DIR}"; exit 1; fi

[[ ! -f "${CNCLI}" ]] && echo -e "\nERROR: failed to locate cncli executable, please install with 'guild-deploy.sh'\n" && exit 1
CNCLI_VERSION="v$(cncli -V | cut -d' ' -f2)"
if ! versionCheck "6.0.0" "${CNCLI_VERSION}"; then echo "ERROR: cncli ${CNCLI_VERSION} installed, minimum required version is 6.0.0, please upgrade to latest version!"; exit 1; fi
CNCLI_VERSION="$(${CNCLI} -V | cut -d' ' -f2)"
if ! versionCheck "6.5.1" "${CNCLI_VERSION}"; then echo "ERROR: cncli ${CNCLI_VERSION} installed, minimum required version is 6.5.1, please upgrade to latest version!"; exit 1; fi

[[ -z "${CNCLI_DIR}" ]] && CNCLI_DIR="${CNODE_HOME}/guild-db/cncli"
if ! mkdir -p "${CNCLI_DIR}" 2>/dev/null; then echo "ERROR: Failed to create CNCLI DB directory: ${CNCLI_DIR}"; exit 1; fi
Expand Down

0 comments on commit 947f152

Please sign in to comment.