merge logmonitor and startup logmonitor #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBenson
force-pushed
the
combine-log-monitoring
branch
from
578e9e4 to
a4fcfad
Compare
|
Cannot auto-update because of conflicts. |
|
I'll look at the conflict today. |
I'm guessing github mobile was mistakenly still showing me a merge conflict resolved when 8bad716 was merged, prior to this earlier response... My browser never seemed to show there being a conflict, and merging into alpha in a fork works after reset and sync for commits to alpha since this message. 🤷 |
|
@gufmar - any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined functionality of logMonitor and startupLogMonitor into a single script.
Testing
Requirements
Checkout the code
Use
guild-deploy.shto target the branch.Use
deploy-as-systemd.shto setup at minimum cnode and logmonitor.Testing original functionality
The RestartSec has been lowered to 1 second. Sourcing was set to offline mode with
env offline. The change in timing allows tracking chunk validation and ledger replay events.Testing specific to startup log
/opt/cardano/cnode/scripts/cncli.sh initkill -9on the pid of your cardano-node to cause an unclean shutdown and the next time the node starts it will perform chunk validation and replay the ledger and the associated tables will have entries.