Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly deploy mithril scripts #1698

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Properly deploy mithril scripts #1698

merged 3 commits into from
Nov 2, 2023

Conversation

TrevorBenson
Copy link
Collaborator

@TrevorBenson TrevorBenson commented Nov 2, 2023 •
edited
Loading

The scripts were left out and not updated during force overwrites. This PR addresses it.

  • guild-deploy.sh
    • Uses updateWithCustomConfig() to deploy mithril scripts when files are downloaded or overwritten.
    • Updates the FORCE_OVERWRITE message to mention mithril scripts.
    • Removes WANT_BUILD_DEPS from option m as Mithril installs release binaries.
  • Sets mithril-relay.sh and mithril-client.sh executable bit.
  • Bumps mithril to release v2342.0
  • Always create mithril directories on first pass.

@TrevorBenson TrevorBenson requested a review from Scitz0 November 2, 2023 04:54
@TrevorBenson TrevorBenson requested a review from rdlrt November 2, 2023 05:03
rdlrt
rdlrt approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdlrt rdlrt merged commit 6aaed1b into alpha Nov 2, 2023
3 checks passed
@rdlrt rdlrt deleted the mithril-use-updatewithcustomconfig branch November 2, 2023 05:17
@rdlrt rdlrt restored the mithril-use-updatewithcustomconfig branch November 2, 2023 05:17
@rdlrt rdlrt deleted the mithril-use-updatewithcustomconfig branch November 3, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

@Scitz0 Scitz0 Awaiting requested review from Scitz0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBenson @rdlrt