setup-grest: Improve cleanup of cron scripts and running jobs #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scitz0
approved these changes
Nov 2, 2023
rdlrt
added a commit
that referenced
this pull request
Nov 3, 2023
## Description <!--- Describe your changes --> Currently, setup-grest.sh relies on removing individual files and kill corresponding cron job processes. This can lead to multiple scenarios where old (retired) cron jobs may not be cleaned up, as well as relies on assumptions on nomen clature of running processes (which as seen in #1666 is not always true) - [x] Remove all cron jobs for given `CRON_SCRIPTS_DIR` from /etc/cron.d, as well as empty the `CRON_SCRIPTS_DIR` itself - [x] Use PG_CANCEL_BACKEND and PG_TERMINATE_BACKEND psql calls to terminate all jobs run using installer user as `psql` session (it is a bit aggressive, but does not break any non-psql sessions like an admin client or dbsync - cron jobs always run as psql commands, the only other psql references on gRest nodes should be get-metrics script, which should anyways have a hiccup when removing all gRest functions), rather than having to maintain a list. This is only triggered when using `-q` or `-r` flags. ## Which issue it fixes? <!--- Link to issue: Closes #issue-number --> Closes #1666 ## How has this been tested? <!--- Describe how you tested changes --> Tested in-place update on guildnet node
rdlrt
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, setup-grest.sh relies on removing individual files and kill corresponding cron job processes. This can lead to multiple scenarios where old (retired) cron jobs may not be cleaned up, as well as relies on assumptions on nomen clature of running processes (which as seen in #1666 is not always true)
CRON_SCRIPTS_DIRfrom /etc/cron.d, as well as empty theCRON_SCRIPTS_DIRitselfpsqlsession (it is a bit aggressive, but does not break any non-psql sessions like an admin client or dbsync - cron jobs always run as psql commands, the only other psql references on gRest nodes should be get-metrics script, which should anyways have a hiccup when removing all gRest functions), rather than having to maintain a list. This is only triggered when using-qor-rflags.Which issue it fixes?
Closes #1666
How has this been tested?
Tested in-place update on guildnet node