Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mithril mkdir in scripts for existing deployments #1702

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

TrevorBenson
Copy link
Collaborator

Both mithril-signer and mithril-client will check for directory existence before generating the mithril environment file. If the directory does not exist it will mkdir -p and chown -R.

Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TrevorBenson TrevorBenson force-pushed the mithril-mkdir-in-generate branch from ab56dfa to 7e2dbf8 Compare November 15, 2023 19:59
@TrevorBenson
Copy link
Collaborator Author

Small adjustment to ensure client creates directories even when POOL_NAME is still CHANGEME (for relays or syncing before pool has been created).

Testing

I tested under a RHEL 9 instance. First pass w/ guild-deploy.sh NOT using -s m creates the directories. I then rm -rf'd the ${CNODE_HOME}/mithril path, and used ${CNODE_HOME/scripts/mithril-client.sh -u and it pre-created the directories and set permissions prior to generating the env file. The generate function inside mithril-signer.sh also has the check and mkdir at the very beginning, so should handle it identically.

@Scitz0 Scitz0 merged commit ec89e1b into alpha Nov 15, 2023
1 check passed
@Scitz0 Scitz0 deleted the mithril-mkdir-in-generate branch November 15, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants