Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRB repo installation for RHEL 9 #1703

Merged
merged 3 commits into from
Nov 18, 2023
Merged

CRB repo installation for RHEL 9 #1703

merged 3 commits into from
Nov 18, 2023

Conversation

TrevorBenson
Copy link
Collaborator

Description

Changes the Line 219 and 221 tests from || to &&, making the test for rhel 9 reachable.

Where should the reviewer start?

Line 219 & 221 changed. Full review requires a Red Hat subscription (developer subscriptions are fine too) and registering the system via subscription-manager before running guild-deploy.sh.

Motivation and context

Fixing the codeready builder repository for RHEL 9.

Which issue it fixes?

Closes #1701

How has this been tested?

Fresh RHEL 9 VM created, registered w/ developer subscription enabling only the initial rhel-9-for-x86_64-baseos-rpms and rhel-9-for-x86_64-appstream-rpms default repositories. Then ./guild-deploy.sh -b rhel-9-crb-repo -s pld used to test the branch.

[guild@rhel92 tmp]$ ./guild-deploy.sh -b rhel-9-crb-repo -s pld

Preparing OS dependency packages for "Red Hat Enterprise Linux" system

  Updating system packages...

  Enabling epel repository...

  Symlink updates not required for ncurse libs, skipping..

  Installing missing prerequisite packages, if any..
Importing GPG key 0x3228467C:
 Userid     : "Fedora (epel9) <[email protected]>"
 Fingerprint: FF8A D134 4597 106E CE81 3B91 8A38 72BF 3228 467C
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-9

Installing Haskell build/compiler dependencies (if missing)...

Installing ghcup (The Haskell Toolchain installer) ..

[Re]-Install libsecp256k1 ...

libsecp256k1 installed to /usr/local/lib/

Building libsodium ...

IOG fork of libsodium installed to /usr/local/lib/

Creating Folder Structure ..

Setting up Environment Variable

Downloading files...

Downloading binaries..

  Downloading Cardano Node archive created from IO CI builds..

  Downloading Github release package for Cardano Wallet

  Downloading Cardano DB Sync archive created from IO CI Builds..

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 November 15, 2023 19:23
@TrevorBenson TrevorBenson self-assigned this Nov 15, 2023
@TrevorBenson TrevorBenson changed the title Use DISTRO and VERSION_ID, not or for CRB Use DISTRO and VERSION_ID, "not" (instead of "or") for CRB Nov 15, 2023
@TrevorBenson TrevorBenson changed the title Use DISTRO and VERSION_ID, "not" (instead of "or") for CRB Use DISTRO and VERSION_ID, not "or" for CRB Nov 15, 2023
@TrevorBenson TrevorBenson changed the title Use DISTRO and VERSION_ID, not "or" for CRB Use DISTRO "and" VERSION_ID, not "or" for CRB Nov 15, 2023
@TrevorBenson
Copy link
Collaborator Author

Pre-merge check failure appears to be ogmios based:

280.8 Installing Ogmios
115
281.3 curl: no URL specified!
116
281.3 curl: try 'curl --help' for more information
117
281.3 ERROR: Download of latest release of ogmios archive from GitHub failed! Please retry or manually install it.

I can see the ogmios_asset_url curl returns. However the json from api.github.com does not appear to have the assets key, but does have an assets_url. I suspect the API implemented a change to the data structure, breaking ogmios setup.

@TrevorBenson
Copy link
Collaborator Author

Pre-merge check failure appears to be ogmios based:

280.8 Installing Ogmios
115
281.3 curl: no URL specified!
116
281.3 curl: try 'curl --help' for more information
117
281.3 ERROR: Download of latest release of ogmios archive from GitHub failed! Please retry or manually install it.

I can see the ogmios_asset_url curl returns. However the json from api.github.com does not appear to have the assets key, but does have an assets_url. I suspect the API implemented a change to the data structure, breaking ogmios setup.

Took a closer look during lunch and it seems that browser_download_url exists, its just no longer in the response's first indice of the first list.

$ curl -s https://api.github.com/repos/CardanoSolutions/ogmios/releases | jq '.[0].assets[].browser_download_url'
[guild@rhel92 tmp]$ 

However it is now part of the second (1) indice of the first list .[1].assets.browser_download_url:

curl -s https://api.github.com/repos/CardanoSolutions/ogmios/releases | jq '.[1].assets[].browser_download_url'
"https://github.com/CardanoSolutions/ogmios/releases/download/v6.0.0-rc4/ogmios-v6.0.0-rc4-x86_64-linux.zip"
[guild@rhel92 tmp]$ 

VERSION_ID is already being filtered for 8/9 on L213, so we can simply take major version release from variable itself
@rdlrt
Copy link
Contributor

rdlrt commented Nov 15, 2023

it is now part of the second (1) indice of the first list .[1].assets.browser_download_url:

That is simply because the pre-compiled artefacts for ogmios have not yet been uploaded, outside of current PR's scope

@TrevorBenson TrevorBenson changed the title Use DISTRO "and" VERSION_ID, not "or" for CRB CRB repo installation for RHEL 9 Nov 16, 2023
@rdlrt rdlrt merged commit 7f8ca9b into alpha Nov 18, 2023
1 of 3 checks passed
@rdlrt rdlrt deleted the rhel-9-crb-repo branch November 18, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest guild-deploy.sh doesn't install the epel repo for rhel 9 and there is a bad condition statement
2 participants