-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRB repo installation for RHEL 9 #1703
Conversation
Pre-merge check failure appears to be ogmios based:
I can see the ogmios_asset_url curl returns. However the json from api.github.com does not appear to have the assets key, but does have an assets_url. I suspect the API implemented a change to the data structure, breaking ogmios setup. |
Took a closer look during lunch and it seems that browser_download_url exists, its just no longer in the response's first indice of the first list.
However it is now part of the second (1) indice of the first list
|
VERSION_ID is already being filtered for 8/9 on L213, so we can simply take major version release from variable itself
That is simply because the pre-compiled artefacts for ogmios have not yet been uploaded, outside of current PR's scope |
ef66c62
to
67c6cc6
Compare
Description
Changes the Line 219 and 221 tests from
||
to&&
, making the test for rhel 9 reachable.Where should the reviewer start?
Line 219 & 221 changed. Full review requires a Red Hat subscription (developer subscriptions are fine too) and registering the system via
subscription-manager
before runningguild-deploy.sh
.Motivation and context
Fixing the codeready builder repository for RHEL 9.
Which issue it fixes?
Closes #1701
How has this been tested?
Fresh RHEL 9 VM created, registered w/ developer subscription enabling only the initial rhel-9-for-x86_64-baseos-rpms and rhel-9-for-x86_64-appstream-rpms default repositories. Then
./guild-deploy.sh -b rhel-9-crb-repo -s pld
used to test the branch.