Update dockerfile_bin to use ${GUILD_DEPLOY_BRANCH} instead of master #1730
Conversation
There was a problem hiding this comment.
While updating this particular instance might be OK - these should not get published/tagged as latest docker images , as anything not on master is not tested in field yet - which should anyways be achieved using github workflow's branch tag (being master). Hence, approving
…#1730) ## Description Changes `files/docker/node/dockerfile_bin` to always rely on the GUILD_DEPLOY_BRANCH for the `guild-deploy.sh` file as well as the configuration files. ## Where should the reviewer start? ## Motivation and context Changes merged altering `config-mainnet.json` to `files/config/mainnet/config.json` leads to failures to build the image. Can be observed in [this job run](https://github.com/cardano-community/guild-operators/actions/runs/7690838700). Changing `dockerfile_bin` to use the **GUILD_DEPLOY_BRANCH** does work. It also ensures a container that is intended to test a specific set of changes obtains the **addons**, **scripts**, or **entrypoint.sh** for the container from the same branch intended for testing. ## Which issue it fixes? Didn't open an issue, just created the branch and tested the fix. Can open one if we want the PR to track closing an issue. ## How has this been tested? The working job from this branch can be observed in [this job run](https://github.com/cardano-community/guild-operators/actions/runs/7690854231).
Agreed. During an earlier change I put a "safety valve" in, so if the workflow runs, even if someone uses the workflow dispatch and does NOT set it to testing, if the branch isn't master it won't push a new image up to hub.docker.com. |
Description
Changes
files/docker/node/dockerfile_binto always rely on the GUILD_DEPLOY_BRANCH for theguild-deploy.shfile as well as the configuration files.Where should the reviewer start?
Motivation and context
Changes merged altering
config-mainnet.jsontofiles/config/mainnet/config.jsonleads to failures to build the image. Can be observed in this job run.Changing
dockerfile_binto use the GUILD_DEPLOY_BRANCH does work. It also ensures a container that is intended to test a specific set of changes obtains the addons, scripts, or entrypoint.sh for the container from the same branch intended for testing.Which issue it fixes?
Didn't open an issue, just created the branch and tested the fix. Can open one if we want the PR to track closing an issue.
How has this been tested?
The working job from this branch can be observed in this job run.