Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-deps.json for node dependencies when running guild-deploy.sh #1739

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

rdlrt
Copy link
Contributor

@rdlrt rdlrt commented Mar 13, 2024

Description

IO teams have updated documentation to use IOHK Nix references for build dependencies. However:

  1. these dependencies are not consistent between 8.7.3 and 8.9.0 (8.7.3 has references to rev while 8.9.0 has ref for some components).
  2. Also, we've burnt ourselves a few times trying to rely on standardisation on that repo as it can change with time.

Hence, with this PR - we start maintaining our own node dependencies matrix for components and start filling/using versions from there instead, with fallback to hardcoded references should someone try to build using custom commits. This should help have control when bumping for patches so that same scripts working on x commit does not stop working after few days without any change in this repo.

@rdlrt rdlrt requested review from Scitz0 and TrevorBenson March 13, 2024 01:31
@rdlrt rdlrt changed the title Add node deps for guild-deploy.json Add node-deps.json for node dependencies when running guild-deploy.sh Mar 13, 2024
Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdlrt rdlrt force-pushed the guild-deploy-patch branch from 7f1e711 to bbf63d0 Compare March 13, 2024 07:46
@rdlrt rdlrt merged commit 00807de into alpha Mar 13, 2024
@rdlrt rdlrt deleted the guild-deploy-patch branch March 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants