-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mithril-client-updates-and-docs #1741
Mithril-client-updates-and-docs #1741
Conversation
A few notes looking at the PR.
|
(cherry picked from commit 18e2813abd7af68e902b2cdc13c82a0440e0d28f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. One thing I noticed was that sidebar.md file had path to mithril-overview as Scripts/mithril-overview.md
while actual file seems to reside in Mithril/
. I guess changing sidebar.md file would be the easier thing as overview isn't just about the scripts but also general information so fine to keep in separate dir outside of Scripts to me.
EDIT
Can you also please move images to images branch and link to that instead like we have done for other.
that's to make it easier to avoid downloading images when cloning + be able to update image corrections w/o PRs
c71a315
to
38934fc
Compare
@Scitz0 Should be ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Updates the mithril-client wrapper script to provide access to each of the mithril-client binaries commands and subcommands for ease of use (provides all the parameters and arguments for each command).
Includes documentation on using the mithril-client.sh to download a latest snapshot, list all snapshots, or show a specific one, as well as download or list available stake-distributions. List and show commands allow json output formats for integration with other tools/purposes.