Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configs and node version support for 8.9.x #1743

Merged
merged 10 commits into from
Apr 21, 2024
Merged

Update configs and node version support for 8.9.x #1743

merged 10 commits into from
Apr 21, 2024

Conversation

rdlrt
Copy link
Contributor

@rdlrt rdlrt commented Mar 18, 2024 •
edited
Loading

Description

  • Update topology formats
  • Update baseline node version references
  • Update node/cli dependency refs and pre-downloaded binaries
  • Update document references
  • Update dbsync version

@rdlrt rdlrt requested a review from Scitz0 March 18, 2024 03:58
@rdlrt rdlrt requested review from TrevorBenson and hodlonaut March 18, 2024 03:59
Scitz0
Scitz0 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leonfs
Copy link

leonfs commented Mar 25, 2024 •
edited
Loading

Is there an expected date of when this PR will be merged? And thanks for the great work!

@Scitz0
Copy link
Contributor

Scitz0 commented Mar 25, 2024

Is there an expected date of when this PR will be merged? And thanks for the great work!

No date as of yet but you can always apply it by adding the running parameter -b node-8.9.0 when executing the scripts.

@leonfs
Copy link

leonfs commented Mar 26, 2024

Thanks, @Scitz0. I tend to rely on the docker build, which I'm guessing it will be pushed once this gets merged. No worries though, I guess it can wait.

Running on docker is tricky, even the Mithril scripts are focused on the host based deployment model. I'll see what docker based solution I might come up with and share it.

Anyway, thanks for the work.

@rdlrt rdlrt changed the title Update configs and node version support for 8.9.0 Update configs and node version support for 8.9.x Mar 27, 2024
@rdlrt
Copy link
Contributor Author

rdlrt commented Mar 27, 2024

@leonfs - Unfortunately, we cannot go ahead with merging this until we have a proper compatibility matrix between different components (currently, node and CLI teams work closely and seem to be part of release, while other components are left as external with a very vague situation). Hence, our guild-ops official support stays at 8.7.3 🙂

spowser and others added 2 commits April 1, 2024 17:36
@spowser
Node 8.9.0 hotfix (#1745)
7cda578 
## Description
Fixes to binary download option

## Where should the reviewer start?
Ensure the -s d option works correctly

## Motivation and context
Tried the `node-8.9.0` branch and ran into issues with where the script
was looking for various binaries

## Which issue it fixes?
Did not create an issue

## How has this been tested?
Used it on my relay to test
@rdlrt
Use strip-components argument and remove 'bin/' folder creation
7303cca
@Fuma419 Fuma419 mentioned this pull request Apr 9, 2024
Merged
@rdlrt rdlrt merged commit a8743cb into alpha Apr 21, 2024
3 checks passed
@rdlrt rdlrt deleted the node-8.9.0 branch April 21, 2024 08:45
rdlrt added a commit that referenced this pull request Apr 21, 2024
@rdlrt
Update configs and node version support for 8.9.x (#1743)
d182431
TrevorBenson pushed a commit to TrevorBenson/guild-operators that referenced this pull request Apr 28, 2024
@rdlrt @TrevorBenson
Update configs and node version support for 8.9.x (cardano-community#…
4daf708 
…1743)

## Description
<!--- Describe your changes -->

- [x] Update topology formats
- [x] Update baseline node version references
- [x] Update node/cli dependency refs and pre-downloaded binaries
- [x] Update document references
- [x] Update dbsync version
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this pull request Apr 28, 2024
@TrevorBenson @rdlrt
Issue/1756 mithril script updates (#27)
4c37b1d 
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* Update configs and node version support for 8.9.x (cardano-community#1743)

## Description
<!--- Describe your changes -->

- [x] Update topology formats
- [x] Update baseline node version references
- [x] Update node/cli dependency refs and pre-downloaded binaries
- [x] Update document references
- [x] Update dbsync version

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* linting and indentation consistentcy for entrypoint.sh

* Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
   - When branch preview/sanchonet use prerelease node version.
   - For any other branch use the original logic for latest (stable) node version.

---------

Co-authored-by: RdLrT <[email protected]>
rdlrt added a commit that referenced this pull request May 3, 2024
@Fuma419 @rdlrt
@spowser @TrevorBenson
moving pr 1743 to node 8.9.1 (#1747)
521a2b0 
## Description

- Branched from:
#1743
- Updated CARDANO_NODE_VERSION to 8.9.1
- updated node-deps.json to 8.9.1
- updated blst to latest per release specs
- Added Fork/Branch ARG to dockerfile_bin & entrypoint.sh to enable
docker test/dev on forked repos
- added missing jg dep in docker build based on build errors


## Where should the reviewer start?
This should be merged into the original branch (node-8.9.0) and tested
more extensively. I can help in that effort but this is my first
contribution and my automated test env and familiarity is lacking.

## Motivation and context
- Reduce node release implementation timetable for guild-operators
docker images.
- Enable docker development from Forks
- Give back and contribute to the
[guild-operators](https://github.com/cardano-community/guild-operators)

## Which issue it fixes?
updating this existing branch (node-8.9.0) to 8.9.1 release ref PR:
(#1743)

## How has this been tested?
Successfully deployed and completely synced nodes using the Docker image
and Host env on mainnet, preprod, preview networks. No further
functionality has been verified. This should be considered as untested
and is not ready for production.

---------

Co-authored-by: rdlrt <[email protected]>
Co-authored-by: Shane Powser <[email protected]>
Co-authored-by: Ben Zawodni <[email protected]>
Co-authored-by: illuminatus <[email protected]>
Co-authored-by: fuma419 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitz0 Scitz0 Scitz0 approved these changes

@TrevorBenson TrevorBenson TrevorBenson approved these changes

@hodlonaut hodlonaut Awaiting requested review from hodlonaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rdlrt @leonfs @Scitz0 @TrevorBenson @spowser