Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decompress resonse when appropriate, fixes #46 #47

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

safanaj
Copy link
Contributor

@safanaj safanaj commented Jan 24, 2024

Description

decode compressed response

Motivation and context

the deflate case is not really needed as the API is using gzip, it is there for completeness

Which issue it fixes?

Closes: #46

How has this been tested?

Manually

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (680d504) 57.51% compared to head (9110de2) 11.67%.

Files Patch % Lines
response.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
- Coverage   57.51%   11.67%   -45.84%     
===========================================
  Files          14       14               
  Lines        1384     1396       +12     
===========================================
- Hits          796      163      -633     
- Misses        500     1227      +727     
+ Partials       88        6       -82     
Flag Coverage Δ
AccountAddresses ?
AccountAssets ?
AccountHistory ?
AccountInfo ?
AccountInfoCached ?
AccountRewards ?
AccountUpdates ?
Accounts ?
AddressAssets ?
AddressInfo ?
AddressTxs ?
AssetAddresses ?
AssetHistory ?
AssetInfo ?
AssetPolicyInfo ?
AssetSummary ?
AssetTxs ?
Assets ?
BlockInfo ?
BlockTxs ?
Blocks ?
CredentialTxs ?
DatumInfo ?
EpochBlockProtocols ?
EpochInfo ?
EpochParams ?
NativeScriptList ?
NetworkGenesis ?
NetworkTip ?
NetworkTotals ?
PlutusScriptList ?
PoolBlocks ?
PoolDelegators ?
PoolDelegatorsHistory ?
PoolHistory ?
PoolInfo ?
PoolMetadata ?
PoolRelays ?
PoolSnapshot ?
PoolUpdates ?
Pools ?
ScriptRedeemers ?
TxInfo ?
TxMetaLabels ?
TxMetadata ?
TxStatus ?
TxUTxO ?
account ?
address ?
assets ?
blocks ?
epoch ?
guild ?
linux 11.67% <0.00%> (-0.11%) ⬇️
local 11.67% <0.00%> (-0.11%) ⬇️
macos 11.67% <0.00%> (-0.11%) ⬇️
mainnet ?
network ?
pool ?
preprod ?
preview ?
scripts ?
transactions ?
windows 11.67% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkungla mkungla closed this Jan 30, 2024
@mkungla mkungla reopened this Jan 30, 2024
@mkungla mkungla merged commit 87385b6 into cardano-community:main Jan 30, 2024
13 of 16 checks passed
@mkungla
Copy link
Member

mkungla commented Jan 30, 2024

thanks fixed and updated cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decompress when Content-Encoding is in the headers
2 participants