Build with GHC 9.2.8.
#4171
Closed
Build with GHC 9.2.8.
#4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
927ad97 to
8468e45
Compare
jonathanknowles
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## Issue Related to #4171. ## Description This PR selectively applies suggestions from the latest version of [`hlint`](https://github.com/ndmitchell/hlint) ([`3.6.1`](https://github.com/ndmitchell/hlint/releases/tag/v3.6.1)). ## Motivation This will make it easier to upgrade our build environment to use GHC version `9.2` or later, which will require us to upgrade to a newer version of `hlint`. Our `nix` environment is currently only configured to use version [`3.3`](https://github.com/ndmitchell/hlint/releases/tag/v3.3) of `hlint`, which was released on`2021-03-15`. Note that we can't upgrade to a newer version of `hlint` without also upgrading GHC to at least version `9.2`.
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
7262dee to
c501b2e
Compare
jonathanknowles
changed the base branch from
master
to
jonathanknowles/diff-friendly-import-style
jonathanknowles
changed the title
9.2.8.
jonathanknowles
force-pushed
the
jonathanknowles/diff-friendly-import-style
branch
from
4c69133 to
bf69969
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
c501b2e to
472f3aa
Compare
jonathanknowles
force-pushed
the
jonathanknowles/diff-friendly-import-style
branch
from
bf69969 to
406576c
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
472f3aa to
c052da1
Compare
jonathanknowles
changed the title
9.2.8.9.2.8.
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
c052da1 to
8f6fdfb
Compare
Base automatically changed from
jonathanknowles/diff-friendly-import-style
to
master
October 20, 2023 08:40
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
8f6fdfb to
fda9a8c
Compare
jonathanknowles
changed the base branch from
master
to
jonathanknowles/ghc-9.2-compatibility
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2-compatibility
branch
from
4c83203 to
12ebe22
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
fda9a8c to
7a8994c
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2-compatibility
branch
from
12ebe22 to
ca75cd1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
This PR includes a small number of patches that enable compatibility with GHC 9.2, while retaining compatibility with GHC 8.10.7. (Note that this PR does **_not_** change the GHC version used in our nix environment, which remains at 8.10.7. For a PR that changes our nix environment to use GHC version 9.2.8, see: #4171)
Base automatically changed from
jonathanknowles/ghc-9.2-compatibility
to
master
October 26, 2023 09:32
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
7a8994c to
b18f000
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.2.8
branch
from
b18f000 to
022e1c7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
Discovered while using the most recent version of [`hlint`](https://github.com/ndmitchell/hlint) ([`3.6.1`](https://github.com/ndmitchell/hlint/releases/tag/v3.6.1)). Note that version 3.6.1 of `hlint`: - is not available in our current `nix` shell. - does not appear to support versions of GHC before 9.2 ([source](https://github.com/ndmitchell/hlint/blob/ed1259a7da88420e8d05d6241d6bdd4493a9997f/hlint.cabal#L39 )). See also: #4171
|
Closing in favor of the update to GHC 9.6.3, #4396 . |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts our
nixconfiguration to build with GHC version9.2.8by default.Related Issues
hlintsuggestions from the future. #4172