Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3368] Fix Github Action for E2E Windows tests #4660

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[ADP-3368] Fix Github Action for E2E Windows tests #4660

merged 2 commits into from
Jul 3, 2024

Conversation

HeinrichApfelmus
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus commented Jul 2, 2024 •
edited
Loading

This pull request fixes the Github Action for the E2E Windows tests. In particular, we

  • Use Ruby setup based on Gemfile
  • Increate timeout of wait_until_node_synced

Issue number

ADP-3368

@HeinrichApfelmus HeinrichApfelmus self-assigned this Jul 2, 2024
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/windows-e2e-action branch 9 times, most recently from c8882ec to 5850024 Compare July 3, 2024 11:34
@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review July 3, 2024 11:34
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/windows-e2e-action branch from 5850024 to 190b829 Compare July 3, 2024 11:35
@HeinrichApfelmus HeinrichApfelmus requested a review from paolino July 3, 2024 11:50
paolino
paolino approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 180 mins for replaying seems a lot ? But that's what it was .

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit e105697 Jul 3, 2024
3 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/ADP-3368/windows-e2e-action branch July 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeinrichApfelmus @paolino