Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3368] Fix Cardano.Wallet.Version #4662

Merged
merged 2 commits into from
Jul 4, 2024
Merged

[ADP-3368] Fix Cardano.Wallet.Version #4662

merged 2 commits into from
Jul 4, 2024

Conversation

HeinrichApfelmus
Copy link
Contributor

This pull request moves the module Cardano.Wallet.Version to the cardano-wallet-api package so that it takes the version number from the same cabal file as the executable, not the cabal file of the library.

Issue Number

ADP-3368

@HeinrichApfelmus HeinrichApfelmus self-assigned this Jul 3, 2024
@HeinrichApfelmus HeinrichApfelmus changed the title [ADP-3368] Heinrich apfelmus/adp 3368/fix version [ADP-3368] Fix Cardano.Wallet.Version Jul 3, 2024
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/fix-version branch from f59bd3a to 840691f Compare July 3, 2024 13:51
@HeinrichApfelmus HeinrichApfelmus requested a review from paolino July 3, 2024 14:18
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/fix-version branch from 840691f to 00ead64 Compare July 3, 2024 15:50
paweljakubas
paweljakubas approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/wallet/exe/cardano-wallet.hs was redundant or not used hence you deleted it?

@HeinrichApfelmus
Copy link
Contributor Author

lib/wallet/exe/cardano-wallet.hs was redundant or not used hence you deleted it?

Yes. 🤓

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3368/fix-version branch from 00ead64 to 5a62ddf Compare July 4, 2024 12:39
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Jul 4, 2024
Merged via the queue into master with commit 855c050 Jul 4, 2024
3 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/ADP-3368/fix-version branch July 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@paolino paolino Awaiting requested review from paolino

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeinrichApfelmus @paweljakubas