-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3215] Add TxOut
type to Cardano.Wallet.Read.Tx
#4698
[ADP-3215] Add TxOut
type to Cardano.Wallet.Read.Tx
#4698
Conversation
110c102
to
6c4f4ef
Compare
d1f3523
to
1deb893
Compare
6c4f4ef
to
2e76e46
Compare
98cb734
to
5c53c1d
Compare
97a580a
to
bd7f665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first look
bd7f665
to
c5c9701
Compare
As discussed, I have
In lieu of the tests relating to
In the interest of development time, I have refrained from adding further tests on |
c5c9701
to
933b15f
Compare
This pull request adds a type
TxOut
toCardano.Wallet.Read.Tx.TxOut
.The type
TxOut
occupies the following point in the design space:TxOut
is era-independent — a value of this type can be any transaction output from a past era.TxOut
can — in principle — be deconstructed using functions from the latest or next era. This is possible because transaction outputs are upwards-compatible.TxOut
can be serialized and deserialized to a format that is close to the ledger CBOR. However, we allowserialize . deserialize ≠ id
in order to allow internal era upgrades.The above design choices can be realized with different internal representations. We choose the following:
TxOut
is represented as a disjoint sum ofOutput era
.TxOut
supports explicit an upgrade toOutput era
whereera
is the latest or next era — but this conversion is not zero-cost.Comments
mkBasicTxOut
for convenience and testing.Issue Number
ADP-3215