[ADP-3339] Prepare UI server support #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
approved these changes
Aug 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
This PR is almost a pure refactoring to prepare the main application to run multiple http services. I added a sub one that will be replaced with the UI service later - [x] Add cli options to control the presence of the UI server on a different port than API server - [x] Move non-api http server code from api package to exe package (including tls module) - [x] Add support for a do-nothing service running along the main api service ADP-3339
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
from
c1c1bc9 to
e6a3765
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
5 times, most recently
from
10cf128 to
43f38aa
Compare
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
from
43f38aa to
4652108
Compare
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
from
4652108 to
8a63b1f
Compare
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
from
8a63b1f to
53e1509
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
8 times, most recently
from
a7c2788 to
8d1befb
Compare
paolino
force-pushed
the
paolino/ADP-3339/prepare-ui-support
branch
from
8d1befb to
9d2d9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is almost a pure refactoring to prepare the main application to run multiple http services. I added a sub one that will be replaced with the UI service later
ADP-3339