[ADP-3215] Add Value type to Cardano.Wallet.Read
#4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a type
ValuetoCardano.Wallet.Read, which mirrors the typeValuefrom the ledger specification.This type occupies the following point in the design space:
Valueis an abstract data type, but accompanied by a pattern synonym.Valueis era-independent.Valuehas zero-cost conversion toMaryValuefromcardano-ledger-mary.The goal is to make this type convenient, but also efficient to use in the context of reading blocks from the Cardano blockchain.
Comments
subtractorlessOrEqualthat are relevant for the Deposit Wallet, but did not go into the details of theMultiAssettype — this can be amended later.Issue Number
ADP-3215