[ADP-2565] Use Database.Table.SQLite.Simple in Deposit Wallet
#4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-2565/db-deposit
branch
from
b8ddc66 to
57540fc
Compare
Anviking
approved these changes
Aug 5, 2024
We have to increase the delay in `postTx` of the mock environment.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-2565/db-deposit
branch
from
57540fc to
8c0211b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the Deposit Wallet to use the database functionality from
Database.Table.SQLite.Simple.At the moment, this actually means removing all database usage from the Deposit Wallet — the mock environment does not need it, and also cannot use it, as the
SqlMmonad is not an instance ofMonadSTM. (For good reason: TheSqlMmonad meant to represent atomic database operations and is not an instance ofMonadIO).However, I want to keep the module
Cardano.Wallet.Deposit.IO.DBaround as a small indirection overDatabase.Table.SQLite.Simple.Issue Number
ADP-2565