[ADP-3344] Use cardano-wallet-read from a different repository
#4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/transplant-read
branch
2 times, most recently
from
1257cc8 to
315eda3
Compare
paolino
changed the title
cardano-wallet-read from a different repositorycardano-wallet-read from a different repository
… and remove `lib/read`.
Changes are minor.
… in a minimal way.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/transplant-read
branch
from
315eda3 to
d6b49c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes our codebase to use the
cardano-wallet-readpackage from the cardano-wallet-agda repository and removes our version of the package here.Comments
cardano-wallet-readon CHaP and import it from there, but at the moment, we use asource-repository-packagestanza to get the package in scope.customer-deposit-walletonly minimally, essentially keeping thefromRawAddressandtoRawAddressfunctions. They will be removed in future pull requests.Issue Number
ADP-3344