Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3414] Optimize benchmark history tracking #4755

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Aug 27, 2024

This PR refactors and improve buildkite lib.

  • Introduces a LimitsLock object to avoid 429 when the 200 API calls per minute are surpassed.
  • Factor out code from the benchmark-history exe into the buildkite lib

I also compute the benchmark history incrementally, by adding new data points to the last checkpoint

  • Exposes the csv database of benchmarks for further reuse
  • Catch that csv while collecting new benchmark results, stopping the collection there and simply amending it

@paolino paolino self-assigned this Aug 27, 2024
@paolino paolino added the CI CI related label Aug 27, 2024
@paolino paolino force-pushed the paolino/ADP-3414/optimize-benchmark-history-tracking branch 9 times, most recently from a5fca07 to 200e60c Compare August 27, 2024 15:27
@paolino paolino marked this pull request as draft August 27, 2024 15:32
@paolino paolino force-pushed the paolino/ADP-3414/optimize-benchmark-history-tracking branch 6 times, most recently from 6924e6f to 5a46440 Compare August 27, 2024 17:29
@paolino paolino marked this pull request as ready for review August 27, 2024 17:30
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 😊 Minuscule comments.

I have to admit that I don't understand the interleaving between Stream and IO very well, but the code seems to work, so that's alright.

@paolino paolino force-pushed the paolino/ADP-3414/optimize-benchmark-history-tracking branch from 5a46440 to 1acb0cf Compare August 29, 2024 15:44
@paolino paolino enabled auto-merge August 29, 2024 15:45
@paolino paolino added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@paolino paolino force-pushed the paolino/ADP-3414/optimize-benchmark-history-tracking branch from 1acb0cf to f376a11 Compare August 30, 2024 05:55
@paolino paolino enabled auto-merge August 30, 2024 05:55
@paolino paolino added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit c6aefbe Aug 30, 2024
25 checks passed
@paolino paolino deleted the paolino/ADP-3414/optimize-benchmark-history-tracking branch August 30, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants