-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3414] Optimize benchmark history tracking #4755
Merged
paolino
merged 8 commits into
master
from
paolino/ADP-3414/optimize-benchmark-history-tracking
Aug 30, 2024
Merged
[ADP-3414] Optimize benchmark history tracking #4755
paolino
merged 8 commits into
master
from
paolino/ADP-3414/optimize-benchmark-history-tracking
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5fca07
to
200e60c
Compare
6924e6f
to
5a46440
Compare
HeinrichApfelmus
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 😊 Minuscule comments.
I have to admit that I don't understand the interleaving between Stream
and IO
very well, but the code seems to work, so that's alright.
5a46440
to
1acb0cf
Compare
1acb0cf
to
f376a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and improve buildkite lib.
429
when the 200 API calls per minute are surpassed.I also compute the benchmark history incrementally, by adding new data points to the last checkpoint