Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3432] Add a UI deposit wallet page to initialize the wallet #4773

Merged
merged 18 commits into from
Sep 18, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 10, 2024

  • Collect wallet page common code from the shelley wallet UI
  • Add a wallet page that based on wallet presence on disk alternatively shows
    • The public key of the wallet and the customer discovery limit , if the wallet is on disk
    • 2 forms to create a wallet , if the wallet is not present on disk
      • Both forms are creating a non-signing wallet ATM, so the mnemonics based one is not production ready
  • A simplified runner for the nix env that runs the node and the wallet separately (useful for fast starting the wallet)
  • Workaround an issue during linking in cross-compiling windows executable. ATM , for the windows platform, database persistence is not implementable using sqlite-simple as it conflicts during linking with persistent-sqlite

Notes:

This is the cross compilation error before the sqlite-simple in the last commit:

Listening on port 8315
GHCruntimelinker:fatalerror:Ifoundaduplicatedefinitionforsymbol
sqlite3_mutex_free
whilstprocessingobjectfile
/nix/store/2iaahkxqa564k36zsbvvjrl1d1v7xia3-direct-sqlite-lib-direct-sqlite-x
86_64-w64-mingw32-2.3.29/lib/x86_64-windows-ghc-9.6.6/direct-sqlite-2.3.29-4sYgk
dKULbzEbITAE5vtqr/HSdirect-sqlite-2.3.29-4sYgkdKULbzEbITAE5vtqr.o
Thesymbolwaspreviouslydefinedin
/nix/store/g208baq5d45dpdcg8zldj964wpi2ddh8-persistent-sqlite-lib-persistent-
sqlite-x86_64-w64-mingw32-2.13.3.0/lib/x86_64-windows-ghc-9.6.6/persistent-sqlit
e-2.13.3.0-2cYeK5mKue8gWmhy84urS/HSpersistent-sqlite-2.13.3.0-2cYeK5mKue8gWmhy84
urS.o
Thiscouldbecausedby:
*Loadingtwodifferentobjectfileswhichexportthesamesymbol
*SpecifyingthesameobjectfiletwiceontheGHCicommandline
*Anincorrect`package.conf'entry,causingsomeobjecttobe
loadedtwice.
iserv-proxy-interpreter.exe:munmapForLinker:m32_release_page:Failedtounmap 
503808bytesat0000000059448000:Invalidaddress.
iserv-proxy-interpreter.exe:munmapForLinker:m32_release_page:Failedtounmap 
4096bytesat00000000546f1000:Invalidaddress.
iserv-proxy-interpreter.exe:munmapForLinker:m32_release_page:Failedtounmap 
4096bytesat00000000546f2000:Invalidaddress.
iserv-proxy-interpreter.exe:loadObj"/nix/store/2iaahkxqa564k36zsbvvjrl1d1v7xia
3-direct-sqlite-lib-direct-sqlite-x86_64-w64-mingw32-2.3.29/lib/x86_64-windows-g
hc-9.6.6/direct-sqlite-2.3.29-4sYgkdKULbzEbITAE5vtqr/HSdirect-sqlite-2.3.29-4sYg
kdKULbzEbITAE5vtqr.o":failed
iserv-proxy: <socket: 10>: hGetBufSome: resource vanished (Connection reset by peer)

ADP-3432

@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch 2 times, most recently from c961c6d to b2f9597 Compare September 10, 2024 11:16
@paolino paolino force-pushed the HeinrichApfelmus/ADP-3344/interface-rest branch from 19cecf8 to 053d8b1 Compare September 10, 2024 13:11
Base automatically changed from HeinrichApfelmus/ADP-3344/interface-rest to master September 10, 2024 14:40
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from b2f9597 to 8215b07 Compare September 10, 2024 14:53
@paolino paolino self-assigned this Sep 10, 2024
@paolino paolino added Deposit UI UI related changes labels Sep 10, 2024
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from 8215b07 to d5881e3 Compare September 10, 2024 15:22
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch 4 times, most recently from a8c989c to 70dfa74 Compare September 12, 2024 14:41
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch 11 times, most recently from 192ecee to 4a5ad61 Compare September 16, 2024 11:55
@paolino paolino marked this pull request as ready for review September 16, 2024 11:55
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 😊

I'd like to ask you to move WalletPublicIdentity to the Cardano.Wallet.Deposit.Pure module, as I think that it's definitely a concept on its own and merits being part of the pure Haskell API.

I have skimmed over the HTML stuff, but did check it thoroughly. You know what you're doing there. 👍

@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from 4a5ad61 to 803b85c Compare September 16, 2024 18:16
@paolino paolino enabled auto-merge September 16, 2024 18:16
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from eba8850 to 4afc98b Compare September 16, 2024 18:33
@paolino paolino added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from 4afc98b to d1a77cb Compare September 17, 2024 08:57
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch 8 times, most recently from 5b65e23 to 8367d6f Compare September 18, 2024 13:02
@paolino paolino force-pushed the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch from 8367d6f to 98b9362 Compare September 18, 2024 13:18
@paolino paolino enabled auto-merge September 18, 2024 13:22
@paolino paolino added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit d215d9e Sep 18, 2024
25 checks passed
@paolino paolino deleted the paolino/ADP-3432/add-UI-for-deposit-wallet-creation branch September 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deposit UI UI related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants