Translate possible cases of ErrBalanceTx to ErrCreatePayment
#4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Dec 19, 2024
| @@ -55,15 +78,108 @@ import qualified Data.Text as T | |||
|
|
|||
| data ErrCreatePayment | |||
| = ErrCreatePaymentNotRecentEra (Read.EraValue Read.Era) | |||
| | ErrCreatePaymentBalanceTx (Write.ErrBalanceTx Write.Conway) | |||
| | ErrNotEnoughAda { shortfall :: Value } | |||
There was a problem hiding this comment.
Only providing the shortfall field allows us to merge Write.ErrBalanceTxAssetsInsufficient and Write.ErrBalanceTxUnableToCreateChange, which seems desirable. We'd probably ideally want some more info though.
Anviking
commented
Dec 19, 2024
| @@ -16,6 +16,7 @@ module Cardano.Wallet.Deposit.Write | |||
| , TxBody (..) | |||
| , TxIn | |||
| , TxOut | |||
| , Coin | |||
There was a problem hiding this comment.
Hm, this is probably clashes with the read Coin type
Anviking
commented
Dec 19, 2024
| Write.ErrBalanceTxOutputError (Write.ErrBalanceTxOutputErrorOf ix (Write.ErrBalanceTxOutputAdaQuantityInsufficient{minimumExpectedCoin})) -> | ||
| ErrTxOutAdaInsufficient { outputIx = ix, suggestedMinimum = minimumExpectedCoin } | ||
| Write.ErrBalanceTxOutputError (Write.ErrBalanceTxOutputErrorOf _ix (Write.ErrBalanceTxOutputSizeExceedsLimit{})) -> | ||
| impossible "value can't be too big if there are no assets" |
There was a problem hiding this comment.
Hm, but createPayment does actually take Values and not Coins... This is possible then...
There was a problem hiding this comment.
These are now translated.
Anviking
force-pushed
the
anviking/ErrCreatePayment
branch
2 times, most recently
from
efcbc07 to
9ab7171
Compare
…Limit` While it's not possible to send assets from the deposit wallet ui, this is currently possible with the internal 'createPayment' function.
Anviking
force-pushed
the
anviking/ErrCreatePayment
branch
2 times, most recently
from
176bfe7 to
3210b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrBalanceTxConflictingNetworksErrBalanceTxtoErrCreatePaymentComments
Issue Number
#4877