Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate application tls library #5040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Separate application tls library #5040

wants to merge 4 commits into from
+1,224 −961

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Mar 11, 2025 •
edited
Loading

Changes

  • Create a separate cardano-wallet-application-tls library
  • Use the new lib in cardano-wallet-exe library
  • Rename cardano-wallet-exe lib as cardano-wallet-application
  • cabal-fmt all lib cabal files and enforce it in the CI

Issues

part of #4996

Notes

  • Use just syntax to format cabal files as well

@paolino paolino force-pushed the paolino/4996/separate-application-tls-module branch 6 times, most recently from 078d972 to cb6643b Compare March 12, 2025 09:03
@paolino paolino self-assigned this Mar 12, 2025
@paolino paolino added the Dependencies Pull requests that update a dependency file label Mar 12, 2025
@paolino paolino force-pushed the paolino/4996/separate-application-tls-module branch from cb6643b to a8423ae Compare March 12, 2025 09:18
paweljakubas
paweljakubas approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! if it compiles and all tests pass we should be fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@paolino paolino

Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @paweljakubas