Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi version explorer deployment #22

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Multi version explorer deployment #22

merged 8 commits into from
Feb 10, 2025

Conversation

ch1bo
Copy link
Member

@ch1bo ch1bo commented Feb 7, 2025 •
edited
Loading

Deploys the latest (unstable) docker images of hydra-explorer and hydra-chain-observer to explorer.hydra.family whenever we merge anything to master on this repository.

I tried using nixos-rebuild switch at first, but the services.github-runners nixos option or the github runner service does seem to do some sandboxing and it was not working out of the box.

So I switched to defining a docker-compose.yaml and using docker compose to deploy containers (like it was before from the hydra repo).

NOTE: The CD action will fail until this is merged. I had it working with branch push triggers here: https://github.com/cardano-scaling/hydra-explorer/actions/runs/13207447976.

@ch1bo ch1bo requested review from noonio and a team February 7, 2025 20:26
@ch1bo ch1bo linked an issue Feb 7, 2025 that may be closed by this pull request
Deploy to explorer.hydra.family #1
Closed
@locallycompact
Copy link
Contributor

Explain again what is wrong with nixos rebuild?

@ch1bo
Copy link
Member Author

ch1bo commented Feb 10, 2025

Explain again what is wrong with nixos rebuild?

It didn't work. See for example this build: https://github.com/cardano-scaling/hydra-explorer/actions/runs/13207223652/job/36873147298

@locallycompact
Copy link
Contributor

locallycompact commented Feb 10, 2025 •
edited
Loading

Oh I see. We are running the CI on the same machine as the explorer. This is not ideal, and why we used nixinate previously. I wonder if the sandbox can ssh to the host it is running on, where it could work.

noonio
noonio approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@noonio
Copy link
Contributor

noonio commented Feb 10, 2025

Oh I see. We are running the CI on the same machine as the explorer. This is not
ideal, and why we used nixinate previously. I wonder if the sandbox can ssh to the
host it is running on, where it could work.

I had a similar idea.

I think for now we should just let this go through as-is, and we can revise it into a nice nix derivation a bit later, if we so desire.

@locallycompact locallycompact merged commit c0b8e45 into master Feb 10, 2025
1 check passed
@noonio noonio deleted the multi-version-explorer-deployment branch February 10, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locallycompact locallycompact locallycompact left review comments

@ffakenz ffakenz ffakenz approved these changes

@noonio noonio noonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy to explorer.hydra.family
4 participants
@ch1bo @locallycompact @noonio @ffakenz