Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate URLs as URLs in API #293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Validate URLs as URLs in API #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class PuzzleSerializer(serializers.ModelSerializer):
tags = serializers.SerializerMethodField(required=False)
guesses = serializers.SerializerMethodField()
# Have to specify this explicitly for validate_url to run
url = serializers.CharField()
url = serializers.URLField()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this allow an empty url? I seem to recall we discussed at some point we might want to create a puzzle placeholder where the url was left blank (and perhaps filled in later).

hunt_id = serializers.PrimaryKeyRelatedField(
read_only=True, default=CurrentHuntDefault()
)
Expand Down