menu/UI cleanup #3: click-to-edit on some columns #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2025
npinsker
force-pushed
the
npinsker/refactor-menus-3
branch
from
23207c6 to
773ec99
Compare
npinsker
force-pushed
the
npinsker/refactor-menus-3
branch
from
773ec99 to
5444e31
Compare
npinsker
changed the title
npinsker
changed the title
akirabaruah
reviewed
Jan 16, 2025
akirabaruah
approved these changes
Jan 16, 2025
rgossiaux
requested changes
Jan 16, 2025
| import type { Hunt, Row } from "./types"; | ||
|
|
||
| export default function NotesCell({ row, value }: { row: Row; value: string }) { | ||
| const { id: huntId } = useSelector<RootState, Hunt>((state) => state.hunt); | ||
| const [uiHovered, setUiHovered] = React.useState(false); | ||
| const dispatch = useDispatch(); | ||
| const [uiHovered, setUiHovered] = useState(false); |
There was a problem hiding this comment.
For CSS stuff I think it is much preferable to use :hover to control the interactions rather than to manage it in JS when possible. The JS way is kind of fragile and error prone.
There was a problem hiding this comment.
sorry i jumped the gun on merging this, fixed in #854
| setEditedNotesValue(e.target.value); | ||
| }} | ||
| onKeyDown={(e) => { | ||
| if (e.key === "Enter" && (e.ctrlKey || e.shiftKey || e.metaKey)) { |
There was a problem hiding this comment.
Isn't this a reverse of normal semantics? Normally enter is submit and shift+enter is new line right?
There was a problem hiding this comment.
yeah i thought about this, but notes are often multiline, and i think people are going to get more confused by pressing enter and having it submit. modifier + enter isn't very discoverable, but there's a checkmark button at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the icons entirely. instead, clickable cells will now highlight (with a yellow background) when hovered, indicating an action can be taken. (sorry idk how to take a video) (also sorry the bg is kinda ugly but it's harder to fix because of the
react-tablecomponent we use)resolves #835