Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema type for BaseCSVFilter/ModelChoiceFilter #1202

Closed
wants to merge 3 commits into from

Conversation

wonderbeyond
Copy link

I can not type csv numbers in swagger-ui, so I made this change.

@codecov-io
Copy link

codecov-io commented Apr 21, 2020

Codecov Report

Merging #1202 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   99.44%   99.36%   -0.08%     
==========================================
  Files          15       15              
  Lines        1255     1257       +2     
==========================================
+ Hits         1248     1249       +1     
- Misses          7        8       +1     
Impacted Files Coverage Δ
django_filters/rest_framework/backends.py 98.92% <66.66%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9305753...2dce3e9. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1202 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   99.44%   99.36%   -0.08%     
==========================================
  Files          15       15              
  Lines        1253     1255       +2     
==========================================
+ Hits         1246     1247       +1     
- Misses          7        8       +1     
Impacted Files Coverage Δ
django_filters/rest_framework/backends.py 98.92% <66.66%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b4ea7...d57fdf0. Read the comment docs.

@wonderbeyond wonderbeyond changed the title Fix schema type for BaseCSVFilter Fix schema type for BaseCSVFilter/ModelChoiceFilter Jun 24, 2020
@wonderbeyond
Copy link
Author

Add schema fix for ModelChoiceFilter just now.

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wonderbeyond — Thanks for this.

We need to fix #1243 for the CI, but beyond that I guess we can take this. (The CoreAPI schemas will stop working eventually but you can pin to the last versions that support whilst you're still using them.)

@wonderbeyond
Copy link
Author

Hi @carltongibson can my PR been merged now?

Base automatically changed from master to main March 3, 2021 08:48
@carltongibson
Copy link
Owner

As per #1432 the in-built schema support is going to be deprecated in the next version.

Rather, I recommend you migrate to use drf-spectacular, which is much more fully featured, and under active development.

https://drf-spectacular.readthedocs.io/en/latest/readme.html

If for some reason you're not able to use drf-spectacular you can copy the django_filters.rest_framework.backends.DjangoFilterBackend into your own project to customise as needed. (But use drf-spectacular.)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants