-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema type for BaseCSVFilter/ModelChoiceFilter #1202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 99.44% 99.36% -0.08%
==========================================
Files 15 15
Lines 1255 1257 +2
==========================================
+ Hits 1248 1249 +1
- Misses 7 8 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 99.44% 99.36% -0.08%
==========================================
Files 15 15
Lines 1253 1255 +2
==========================================
+ Hits 1246 1247 +1
- Misses 7 8 +1
Continue to review full report at Codecov.
|
Add schema fix for ModelChoiceFilter just now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wonderbeyond — Thanks for this.
We need to fix #1243 for the CI, but beyond that I guess we can take this. (The CoreAPI schemas will stop working eventually but you can pin to the last versions that support whilst you're still using them.)
Hi @carltongibson can my PR been merged now? |
As per #1432 the in-built schema support is going to be deprecated in the next version. Rather, I recommend you migrate to use https://drf-spectacular.readthedocs.io/en/latest/readme.html If for some reason you're not able to use Thanks. |
I can not type csv numbers in swagger-ui, so I made this change.