Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect to non-string filter types while output OpenAPI parameters #1306

Conversation

wonderbeyond
Copy link

Effect with drf-spectacular:

image

@codecov-io
Copy link

Codecov Report

Merging #1306 (176c0fe) into master (6045fff) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
- Coverage   99.44%   99.44%   -0.01%     
==========================================
  Files          15       15              
  Lines        1265     1250      -15     
==========================================
- Hits         1258     1243      -15     
  Misses          7        7              
Impacted Files Coverage Δ
django_filters/rest_framework/backends.py 100.00% <100.00%> (ø)
django_filters/filters.py 100.00% <0.00%> (ø)
django_filters/filterset.py 100.00% <0.00%> (ø)
django_filters/rest_framework/filterset.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6045fff...176c0fe. Read the comment docs.

Base automatically changed from master to main March 3, 2021 08:48
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please adjust the tests as well to make the CI green?

@carltongibson
Copy link
Owner

As per #1432 the in-built schema support is going to be deprecated in the next version.

Rather, I recommend you migrate to use drf-spectacular, which is much more fully featured, and under active development.

https://drf-spectacular.readthedocs.io/en/latest/readme.html

If for some reason you're not able to use drf-spectacular you can copy the django_filters.rest_framework.backends.DjangoFilterBackend into your own project to customise as needed. (But use drf-spectacular.)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants