Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model multiple list filtering through "," #1492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bubaley
Copy link

@bubaley bubaley commented Apr 20, 2022

Comma separating value in ModelMultipleChoiceField to allow multiple objects to be passed in one query parameter.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.37%. Comparing base (dbc69e7) to head (972ff5a).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
django_filters/fields.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
- Coverage   99.44%   99.37%   -0.08%     
==========================================
  Files          15       15              
  Lines        1270     1276       +6     
==========================================
+ Hits         1263     1268       +5     
- Misses          7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eloi-martinez-qida
Copy link

What does this pr need to be merged? if anything?

@carltongibson
Copy link
Owner

CI failure. No tests, no docs. No discussion about whether it's a desired feature. (For a start).

@eloi-martinez-qida
Copy link

I see, i would say it's a desired feature (at least for me), it would make calling it similar to the Infilter, also, i don't find it very natural tu use the same query key multiples times (in the request).
Maybe it could be parametrized with an optinal argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants