Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When value is a list it should be returned as is (subsum PR 1340) #1637

Merged
merged 4 commits into from
Jan 27, 2024
Merged

When value is a list it should be returned as is (subsum PR 1340) #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c4d3f6
When value is a list it should be returned as is
tony13tv Mar 7, 2021
0e4ccdd
Update test_widgets.py
bryan-brancotte Jan 26, 2024
6ac9301
Merge branch 'main' into patch-2
bryan-brancotte Jan 26, 2024
a8ff978
fixing formatting
bryan-brancotte Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions django_filters/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ def value_from_datadict(self, data, files, name):
if value is not None:
if value == "": # empty value should parse as an empty list
return []
if isinstance(value, list):
# since django.forms.widgets.SelectMultiple tries to use getlist
# if available, we should return value if it's already an array
return value
return value.split(",")
return None

Expand Down
4 changes: 4 additions & 0 deletions tests/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,10 @@ class NumberCSVWidget(BaseCSVWidget, NumberInput):
result = w.value_from_datadict(data, {}, "price")
self.assertEqual(result, ["1", "2"])

data = {"price": ["1", "2"]}
result = w.value_from_datadict(data, {}, "price")
self.assertEqual(result, ["1", "2"])

data = {"price": "1,,2"}
result = w.value_from_datadict(data, {}, "price")
self.assertEqual(result, ["1", "", "2"])
Expand Down
Loading