Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Coverage and Code Tidy #1015

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Test Coverage and Code Tidy #1015

merged 2 commits into from
Dec 17, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 16, 2023

Description:

Related issue (if applicable): n/a

Just some code cleanup; inline documentation updates, spelling errors and more test coverage

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@code-cleanup

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (524eba6) 99.52% compared to head (693b66c) 99.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   99.52%   99.55%   +0.02%     
==========================================
  Files         129      129              
  Lines       17189    17185       -4     
  Branches     3510     3508       -2     
==========================================
+ Hits        17107    17108       +1     
+ Misses         70       68       -2     
+ Partials       12        9       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit cda6925 into master Dec 17, 2023
12 checks passed
@caronc caronc deleted the code-cleanup branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants