-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
realign goals, questions, and content #389
realign goals, questions, and content #389
Conversation
Link to HPC Jargon slides is nice. Some of the wording can be improved. For example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. Have not reviewed section 16 since it will be replaced.
The jargon presentation is not exactly in-scope for this PR, but I've addressed most of these comments in 4089f66. Note that text between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly limited my review to your learning objectives.
I have made a few suggestions where I think the objectives should be reworded or - in one case - split up. A couple points to set out on my reasoning:
- Objectives should be written as endings to a sentence that begins "By the end of this episode, learners should be able to ..."
- The verbs at the beginning of an objective should be active: it is important they are directly measurable/observable because then you can design a formative assessment to evaluate learner attainment during a workshop. Verbs like "understand" and "appreciate" are not directly measurable and should be replaced. (I will submit a separate PR to take care of this in
18-responsibility
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do my review in a few chunks
_episodes/11-connecting.md
Outdated
interface, or GUI. Since computer clusters are remote resources that we connect | ||
to over often slow or laggy interfaces (WiFi and VPNs especially), it is more | ||
practical to use a command-line interface, or CLI, in which commands and | ||
results are transmitted via text, only. Anything other than text (images, for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
results are transmitted via text, only. Anything other than text (images, for | |
results are transmitted via text only. Anything other than text (images, for |
_episodes/11-connecting.md
Outdated
|
||
If you have ever opened the Windows Command Prompt or macOS Terminal, you have | ||
seen a CLI. If you have already taken The Carpentries' courses on the UNIX | ||
Shell or Version Control, you have used the CLI on your local machine somewhat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local machine
is a bit jargon-y I would say, if we are going to use it we should explain early on what is meant by local
and remote
. Perhaps we can use the picture earlier and introduce local
and remote
there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Local" machine/device/computer is used a number of times in the first episode. Perhaps create an issue to place this image in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of effort gone in here, thanks @tkphd!
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: ocaisa <[email protected]>
Co-authored-by: ocaisa <[email protected]>
Co-authored-by: ocaisa <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: ocaisa <[email protected]>
Some initial work on streamlining & refactoring hpc-intro.
Closes #388.
Addresses #387.