Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realign goals, questions, and content #389

Merged
merged 44 commits into from
Jun 3, 2022
Merged

realign goals, questions, and content #389

merged 44 commits into from
Jun 3, 2022

Conversation

tkphd
Copy link
Contributor

@tkphd tkphd commented Mar 17, 2022

Some initial work on streamlining & refactoring hpc-intro.

Closes #388.
Addresses #387.

@tkphd tkphd marked this pull request as draft March 17, 2022 22:05
@tkphd tkphd marked this pull request as ready for review April 8, 2022 17:03
@bkmgit
Copy link
Contributor

bkmgit commented May 7, 2022

Link to HPC Jargon slides is nice. Some of the wording can be improved. For example:

_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
_episodes/14-modules.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bkmgit bkmgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. Have not reviewed section 16 since it will be replaced.

@tkphd
Copy link
Contributor Author

tkphd commented May 16, 2022

Link to HPC Jargon slides is nice. Some of the wording can be improved. For example:

The jargon presentation is not exactly in-scope for this PR, but I've addressed most of these comments in 4089f66. Note that text between ??? and --- represents author notes, which will not be rendered by default.

@tkphd tkphd changed the title rework first couple lessons realign goals, questions, and content May 16, 2022
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly limited my review to your learning objectives.

I have made a few suggestions where I think the objectives should be reworded or - in one case - split up. A couple points to set out on my reasoning:

  1. Objectives should be written as endings to a sentence that begins "By the end of this episode, learners should be able to ..."
  2. The verbs at the beginning of an objective should be active: it is important they are directly measurable/observable because then you can design a formative assessment to evaluate learner attainment during a workshop. Verbs like "understand" and "appreciate" are not directly measurable and should be replaced. (I will submit a separate PR to take care of this in 18-responsibility.)

_config.yml Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/12-cluster.md Outdated Show resolved Hide resolved
_episodes/12-cluster.md Outdated Show resolved Hide resolved
_episodes/13-scheduler.md Outdated Show resolved Hide resolved
_episodes/16-parallel.md Outdated Show resolved Hide resolved
_episodes/17-resources.md Outdated Show resolved Hide resolved
_episodes/15-transferring-files.md Outdated Show resolved Hide resolved
_episodes/14-modules.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do my review in a few chunks

_episodes/10-hpc-intro.md Outdated Show resolved Hide resolved
interface, or GUI. Since computer clusters are remote resources that we connect
to over often slow or laggy interfaces (WiFi and VPNs especially), it is more
practical to use a command-line interface, or CLI, in which commands and
results are transmitted via text, only. Anything other than text (images, for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
results are transmitted via text, only. Anything other than text (images, for
results are transmitted via text only. Anything other than text (images, for

_episodes/11-connecting.md Outdated Show resolved Hide resolved

If you have ever opened the Windows Command Prompt or macOS Terminal, you have
seen a CLI. If you have already taken The Carpentries' courses on the UNIX
Shell or Version Control, you have used the CLI on your local machine somewhat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local machine is a bit jargon-y I would say, if we are going to use it we should explain early on what is meant by local and remote. Perhaps we can use the picture earlier and introduce local and remote there?

Copy link
Contributor

@ocaisa ocaisa May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked on something a bit (in a slide deck), we could introduce it piece by piece
example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Local" machine/device/computer is used a number of times in the first episode. Perhaps create an issue to place this image in there?

_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
_episodes/11-connecting.md Outdated Show resolved Hide resolved
ocaisa
ocaisa previously requested changes May 17, 2022
Copy link
Contributor

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of effort gone in here, thanks @tkphd!

_episodes/12-cluster.md Show resolved Hide resolved
_episodes/13-scheduler.md Outdated Show resolved Hide resolved
_episodes/13-scheduler.md Outdated Show resolved Hide resolved
_episodes/15-transferring-files.md Outdated Show resolved Hide resolved
_episodes/15-transferring-files.md Outdated Show resolved Hide resolved
_episodes/16-parallel.md Show resolved Hide resolved
_episodes/18-responsibility.md Show resolved Hide resolved
tkphd and others added 27 commits June 3, 2022 14:04
Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: ocaisa <[email protected]>
@tkphd tkphd merged commit 354546e into carpentries-incubator:gh-pages Jun 3, 2022
@tkphd tkphd deleted the lesson-objectives-review branch June 3, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

motivate workload managers in ep. 11
7 participants