Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some information on the docker --workdir option #25

Closed
wants to merge 2 commits into from

Conversation

jcohen02
Copy link
Collaborator

This PR aims to address issue #24 by adding a callout box to the end of episode 6 (06-singularity-images-prep.md) describing how the --workdir or -w Docker command line option can help to simplify singularity command lines when using the Docker Singularity container (and especially when using an alias to run the container).

I'd appreciate some feedback from the reviewers on whether the new text is sufficiently clear - this concept was a little challenging to explain clearly so any suggestions on how the text might be improved are welcome.

Copy link

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codeblocks are using more traditional markdown syntax instead of the lesson codeblock syntax. <- this needs to be fixed before merging

Also broke some lines. <- this is mostly style

@jcohen02
Copy link
Collaborator Author

Many thanks for the review and suggestions, @sstevens2, and pointing out the use of the wrong syntax for the codeblocks, I didn't notice that when writing the updated content. Suggestions commited.

@jcohen02 jcohen02 deleted the branch gh-pages September 17, 2024 10:25
@jcohen02 jcohen02 closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants