Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix Node.js warnings linked to GitHub actions #94

Merged
merged 1 commit into from
Sep 5, 2024
Merged

ENH: Fix Node.js warnings linked to GitHub actions #94

merged 1 commit into from
Sep 5, 2024

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Jul 2, 2024

Fix Node.js warnings linked to GitHub actions: bump versions actions/checkout@v4, and actions/upload-artifact@v4

Fixes:

Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

and

Build Full Site
The following actions use a deprecated Node.js version and will be forced to run on node20:
 actions/[email protected].
 For more info:
 https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

raised for example in:
https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282
and
https://github.com/carpentries-incubator/SDC-BIDS-IntroMRI/actions/runs/10578432348

@jhlegarreta
Copy link
Contributor Author

Maybe PR #91 was not enough?

@jhlegarreta
Copy link
Contributor Author

BTW, the OS in the actions is Ubuntu 20.04. Updating it may be appropriate.

@ErinBecker
Copy link
Contributor

Thank you @jhlegarreta for making these fixes. I'm unfortunately not able to merge contributions from accounts with unverified signatures. If you'd like to resubmit after verifying your signature, I'd be happy to merge. Else, I'll go ahead and make these changes in another branch and merge with credit to you.

@jhlegarreta
Copy link
Contributor Author

👍 Will submit with verified signature later today or over the weekend, Erin. Thanks for your work.

@jhlegarreta
Copy link
Contributor Author

Done. Thanks @ErinBecker.

Fix `Node.js` warnings linked to GitHub actions: bump versions
`actions/cache@v4`, `actions/checkout@v4` and
`actions/upload-artifact@v4`.

Fixes:
```
Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

and
```
Build Full Site
The following actions use a deprecated Node.js version and will be forced to run on node20:
 actions/[email protected].
 For more info:
 https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
```

raised for example in:
https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282
and
https://github.com/carpentries-incubator/SDC-BIDS-IntroMRI/actions/runs/10578432348
@ErinBecker
Copy link
Contributor

Thanks @jhlegarreta!

@ErinBecker ErinBecker merged commit e74dd29 into carpentries:main Sep 5, 2024
1 check passed
@jhlegarreta jhlegarreta deleted the FixGitHubActionsNodejsWarning branch September 5, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants