Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .gitkeep files with useful explanation of folder purpose #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

katrinleinweber
Copy link
Contributor

As discussed in #234. make serve is not impacted in any way that I notice. Is the initial text in the ReadMe.md files factually correct?

@katrinleinweber
Copy link
Contributor Author

The build error does not seem to be related to these changes:

In library(package, lib.loc = lib.loc, character.only = TRUE, logical.return = TRUE,  :
  there is no package called ‘requirements’

@fmichonneau
Copy link
Contributor

The relevant build error is:

Error in i.p(...) : 
  (converted from warning) 'lib = "/usr/local/lib/R/site-library"' is not writable"

it is triggered because the Travis file is not set up for R (only Python), and hence the environment variables and library aren't set up to allow package installation.

@katrinleinweber
Copy link
Contributor Author

OK, thanks for explaining. Please feel free to hide my above comment about the resulting error.

Let's focus on the suggested changes again.

@katrinleinweber
Copy link
Contributor Author

I found a possibly even cleaner way to avoid (almost) empty folders:

image

What do you think @rgaiacs & @fmichonneau? Since the makefiles of both lesson-example and styles have the same commit history, I guess such commits should be PR'ed towards the styles repo.

Also: Happy new year, and all the best for 2019 :-)

@fmichonneau fmichonneau changed the base branch from gh-pages to main October 13, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants