Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headings with the title or ID of "resources" are displayed larger #359

Closed
zkamvar opened this issue Nov 2, 2022 · 3 comments
Closed

headings with the title or ID of "resources" are displayed larger #359

zkamvar opened this issue Nov 2, 2022 · 3 comments

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Nov 2, 2022

There is a fun little bug that I saw on someone's personal lesson where they included a section called "resources" at the end of the document. This document happens to have larger than normal text:

Markdown and Screenshots of problem
## Resources

 - [Tidy data vignette](https://cloud.r-project.org/web/packages/tidyr/vignettes/tidy-data.html)
 - [Tidy data paper](https://vita.had.co.nz/papers/tidy-data.pdf)
 - [Data import cheat sheet](https://github.com/rstudio/cheatsheets/blob/main/data-import.pdf)


::::::::::::::::::::::::::::::::::::: keypoints 

- Keeping your data tidy makes it easier to work with
- Use `readxl::read_excel()` to import data from excel
- Use `readr::read_delim()` to import data from delimited text files

::::::::::::::::::::::::::::::::::::::::::::::::

screenshot of resources section with large text

compared to a regular heading:

screenshot of a different section with default text size

source of problem

It's coming from the fact that we have anchors for #chapters and #resources in the CSS for varnish

@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 8, 2022

It turns out that this also poses a navigation problem along with the following headings:

  • chapters (chapter list in the desktop site)
  • resources ("more" menu in the mobile site)
  • to-top (the to top button)
  • expand-code (the "expand all code" button)
  • instructor (mobile view link to instructor view menu)
  • language (mobile view link to language dropdown)
  • eye (anchor for the eye in mobile view; used to add padding to the SVG icon)

I get a feeling that the majority of these are workarounds in the CSS, but it presents a challenge on our side for heading validation that we should not have to do.

@zkamvar
Copy link
Contributor Author

zkamvar commented Jun 26, 2023

tracking in carpentries/varnish#85

@ErinBecker
Copy link
Contributor

Fixed with carpentries/varnish#147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants