This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add date control #112
Open
Add date control #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ const controlTypes = [ | |||
| 'node', | |||
| 'avatar', | |||
| 'name', | |||
| 'date', | |||
There was a problem hiding this comment.
Should we change it to dateString? For date I expected a real Date …
There was a problem hiding this comment.
It is a real date, I just toString it because you can't display it in the UI, Chrome complains.
|
Do not merge until we properly save/restore Dates to the variation files … We can use a similar strategy as for function. Simply identify which properties are dates, then replace them with an ID and the store it as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.