Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release workflow #106

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Refactor release workflow #106

merged 1 commit into from
Oct 18, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Oct 18, 2024

cli, devnet, and mock-verifying-paymaster are npm packages published to the @cartesi npm organization.
Instead of publishing the package in a workflow_call from the release workflow, this changes the publishing to be done in the release workflow itself in the Create Release Pull Request or Publish to npm step.

The publishing of the sdk docker image is still done in a workflow_call.

This will fix the problem that happens in the pre-release scenario, because changeset publish handles the case of specifying the npm tag to pnpm publish automatically.

@tuler tuler requested a review from endersonmaia October 18, 2024 15:09
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 4849ca3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tuler tuler force-pushed the feature/ci-release branch from c2858d2 to 8338955 Compare October 18, 2024 15:09
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 0% 0 / 617
🔵 Statements 0% 0 / 623
🔵 Functions 0% 0 / 84
🔵 Branches 0% 0 / 274
File CoverageNo changed files found.
Generated in workflow #183 for commit 4849ca3 by the Vitest Coverage Report Action

.github/workflows/cli.yaml Show resolved Hide resolved
.github/workflows/cli.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
apps/cli/vitest.config.ts Show resolved Hide resolved
@tuler tuler force-pushed the feature/ci-release branch from ec25d97 to 4849ca3 Compare October 18, 2024 17:37
@tuler tuler requested a review from endersonmaia October 18, 2024 17:37
@tuler tuler merged commit 4686b12 into feature/cli-v2 Oct 18, 2024
4 checks passed
@tuler tuler deleted the feature/ci-release branch October 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants