Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartesi run to rollups-node:2.x #116

Draft
wants to merge 5 commits into
base: prerelease/v2-alpha
Choose a base branch
from

Conversation

endersonmaia
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: df5c0cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 31.07% 293 / 943
🔵 Statements 31.2% 298 / 955
🔵 Functions 36.95% 51 / 138
🔵 Branches 28% 121 / 432
File CoverageNo changed files found.
Generated in workflow #219 for commit df5c0cd by the Vitest Coverage Report Action

@endersonmaia endersonmaia force-pushed the feature/cli-run-v2 branch 3 times, most recently from d8e88da to 1b2868f Compare November 4, 2024 15:30
"0x0000000000000000000000000000000000000000000000000000000000000000",
"0x0000000000000000000000000000000000000000000000000000000000000000",
]
- /bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually don't like to use bash as the command, and instead use the actual process we need to start.
Is this because of env variables?
I understand as well that we need the command stdout to go to a file, in the host .cartesi directory. How are we doing that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a way to debug with -x

About saving do the host, we'd need to mount it into the container and redirect to a file.

Or we'd need to save to a named volume and copy on another process with docker cp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mounting the volume is easy, but how to redirect to a file? Does the following work??

- ">"
- "filename"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for environment variables will be added to the cartesi-rollups-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants