Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ram-image to always be /usr/share/cartesi-machine/images/linux.bin #129

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Nov 8, 2024

This sets the default ram-image path to always be /usr/share/cartesi-machine/images/linux.bin, regardless the system os.
This is the path inside the SDK image that contains the linux.bin as well, so it works if the user does not have cartesi-machine installed on the host, which falls back to executing inside the SDK image container.
If the user does have cartesi-machine installed, and the linux.bin image is located somewhere else, he will need to define the path in the cartesi.toml config file.

@tuler tuler requested a review from endersonmaia November 8, 2024 17:46
Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 079ec9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 31.07% 293 / 943
🔵 Statements 31.2% 298 / 955
🔵 Functions 36.95% 51 / 138
🔵 Branches 28% 121 / 432
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 89.5% 82.02% 96.77% 89.3% 66-67, 215, 222, 231, 246-249, 260, 269, 271, 280, 318, 328-332, 344
Generated in workflow #217 for commit 079ec9a by the Vitest Coverage Report Action

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu Linux 24.04, with and without cartesi-machine available in the host.

@tuler tuler merged commit 21375e8 into prerelease/v2-alpha Nov 11, 2024
2 checks passed
@tuler tuler deleted the feature/ram-image-path branch November 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants