Remove bsdtar usage #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db30df8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
endersonmaia
force-pushed
the
feat/remove-bsdtar-usage
branch
from
ad7ec88 to
5fdec19
Compare
it was used before because of Unicode issues, but that was solved after cartesi/sdk:0.6.1 release that uses most recent version of cartesi/xgenext2fs:1.5.6
endersonmaia
force-pushed
the
feat/remove-bsdtar-usage
branch
from
5fdec19 to
db30df8
Compare
|
closing due to major build refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the dependency on
bsdtar.Depends: #13
Testing this using cartesi/sdk:0.6.0 I get:
Using
cartesi/sdk:0.6.1and removing the usage of bsdtar tool, it builds OK.