-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cpu and mem limits options #65
Conversation
🦋 Changeset detectedLatest commit: 506f441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is a 👍 change! |
Can you rebase to main and apply fixups? |
4c493a1
to
a3e8e3a
Compare
I see that the |
cartesi run --memory 512 --show-config The command above produced the following output: deploy:
resources:
limits:
memory: "536870912" I don't know if that value is correct, as it should be a "byte value". |
The output is after the processing of the values. The |
a3e8e3a
to
ea68daa
Compare
83323e1
to
c3c649b
Compare
adds a `--dry-run` argument to `cartesi run` command so it's possible to see the .yaml file used by docker compose to start the local infratructure
now it is possible to define limits for memory and cpu used for the rollups-node (validator) container, the defaults are generous but can be redefined
c3c649b
to
506f441
Compare
This PR will add
--cpus
and--memory
options forcartesi run
command. This way it will be possible to define these in alignment with the production deployment values and evaluate locally if those values are enough for the application to run smoothly.Also, it was added a hidden
--dry-run
to the run command, that will show the .yaml compose file in case it's needed to debug the compose file.