Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device signer #46

Merged
merged 11 commits into from
Mar 24, 2024
Merged

Add device signer #46

merged 11 commits into from
Mar 24, 2024

Conversation

broody
Copy link
Contributor

@broody broody commented Mar 15, 2024

To integrate webauthn signer into Controller we need to able to trigger device signing/registration from wasm. Currently, only a P256 signer is supported. This PR adds another signer called device and uses the simple wasm-webauthn crate to sign and register.

This is just simple integration to get things working, perhaps it would be best later to adapt wasm-webauthn to our codebase for more control / better testing.

@broody broody force-pushed the device-signer branch 2 times, most recently from a289533 to 2bb4dff Compare March 15, 2024 19:11
@broody broody force-pushed the device-signer branch 5 times, most recently from 0cbc1e4 to e7593d0 Compare March 21, 2024 20:16
@broody broody marked this pull request as ready for review March 21, 2024 22:46
@broody broody requested a review from piniom March 21, 2024 22:47
Copy link
Collaborator

@piniom piniom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok to me.
The public_key_bytes method is a minor thing.

crates/account_sdk/src/webauthn_signer/signers/mod.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 30.66667% with 104 lines in your changes are missing coverage. Please review.

Project coverage is 64.14%. Comparing base (48381d7) to head (cf0bed1).

Files Patch % Lines
.../account_sdk/src/webauthn_signer/signers/device.rs 0.00% 103 Missing ⚠️
.../account_sdk/src/webauthn_signer/signers/p256r1.rs 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   70.65%   64.14%   -6.52%     
==========================================
  Files          16       16              
  Lines        1077     1163      +86     
==========================================
- Hits          761      746      -15     
- Misses        316      417     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broody broody merged commit fd2336f into main Mar 24, 2024
5 of 7 checks passed
@broody broody deleted the device-signer branch March 24, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants