-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device signer #46
Conversation
a289533
to
2bb4dff
Compare
0cbc1e4
to
e7593d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems ok to me.
The public_key_bytes
method is a minor thing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 70.65% 64.14% -6.52%
==========================================
Files 16 16
Lines 1077 1163 +86
==========================================
- Hits 761 746 -15
- Misses 316 417 +101 ☔ View full report in Codecov by Sentry. |
To integrate webauthn signer into Controller we need to able to trigger device signing/registration from wasm. Currently, only a P256 signer is supported. This PR adds another signer called
device
and uses the simplewasm-webauthn
crate tosign
andregister
.This is just simple integration to get things working, perhaps it would be best later to adapt wasm-webauthn to our codebase for more control / better testing.