-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing verified config #1075
Open
JunichiSugiura
wants to merge
15
commits into
main
Choose a base branch
from
feat(keychain)/verified-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,498
−662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 2, 2024 18:29
7b4bbd8
to
f3cfca0
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 2, 2024 18:31
f3cfca0
to
9598283
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 2, 2024 19:11
9598283
to
f2e2dbd
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 3, 2024 14:48
0772ea8
to
4c8b22a
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 3, 2024 16:06
413bd87
to
932fe8a
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 3, 2024 16:28
932fe8a
to
748f9e6
Compare
tarrencev
reviewed
Dec 3, 2024
@@ -112,7 +111,7 @@ export default class ControllerProvider extends BaseProvider { | |||
|
|||
try { | |||
let response = await this.keychain.connect( | |||
this.options.policies || [], | |||
this.options.policies || {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid making any backwards incompatible changes to packages/controller
?
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 4, 2024 14:24
5c8f75c
to
10c75fb
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 4, 2024 14:34
10c75fb
to
9de946f
Compare
JunichiSugiura
force-pushed
the
feat(keychain)/verified-configs
branch
from
December 4, 2024 14:42
9de946f
to
40f9386
Compare
|
…heme module to prevent storybook preview to crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.