Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session summary updates #1111

Merged
merged 17 commits into from
Dec 9, 2024
Merged

Session summary updates #1111

merged 17 commits into from
Dec 9, 2024

Conversation

tarrencev
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 9, 2024 4:54pm
ui-next ✅ Ready (Inspect) Visit Preview Dec 9, 2024 4:54pm

@@ -128,8 +128,7 @@ export function useConnectionValue() {
// Provides backward compatability for Controler <= v0.5.1
if (themeParam) {
const decodedPreset = decodeURIComponent(themeParam);
const parsedTheme = JSON.parse(decodedPreset) as ControllerTheme;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I think we need to keep this unfortunately, since old controllers pass the theme as a json object in the query params

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, putting this in a try/catch

@broody broody merged commit 6c95fc6 into main Dec 9, 2024
18 checks passed
@broody broody deleted the usepolicypresets branch December 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants