Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openSetDelegate(address) #553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add openSetDelegate(address) #553

wants to merge 1 commit into from

Conversation

notV4l
Copy link
Contributor

@notV4l notV4l commented Aug 9, 2024

No description provided.

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cartridge-starknet-react-next ✅ Ready (Inspect) Visit Preview Aug 9, 2024 3:47pm
docs ✅ Ready (Inspect) Visit Preview Aug 9, 2024 3:47pm
keychain ✅ Ready (Inspect) Visit Preview Aug 9, 2024 3:47pm
ui ✅ Ready (Inspect) Visit Preview Aug 9, 2024 3:47pm
ui-next ✅ Ready (Inspect) Visit Preview Aug 9, 2024 3:47pm

@@ -68,6 +68,10 @@ class ControllerConnector extends Connector {
return await this.controller.delegateAccount();
}

async openSetDelegate(address: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this could just be setDelegate, since if the session token is authorized, we could set it without the modal (in the future)

@broody broody force-pushed the main branch 3 times, most recently from 679bdca to d495c0b Compare August 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants