Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run E2E test on CI #567

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Run E2E test on CI #567

wants to merge 10 commits into from
+188 −398

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Aug 13, 2024 •
edited
Loading

Notes

  • This PR requires to set NEXT_PUBLIC_API_URL=integration.cartridge.gg for preview keychain deployments on Vercel

Known issues

  • Example page fail to connect to keychain preview URL when branch name is too long
  • E2E test may not wait until Vercel preview page becomes available
    • Set long enough timeout perhaps?
  • Invalid 'sameOriginWithAncestors' value error on signup via integration.cartridge.gg

@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cartridge-starknet-react-next ✅ Ready (Inspect) Visit Preview Aug 21, 2024 11:23am
docs ✅ Ready (Inspect) Visit Preview Aug 21, 2024 11:23am
keychain ✅ Ready (Inspect) Visit Preview Aug 21, 2024 11:23am
ui ✅ Ready (Inspect) Visit Preview Aug 21, 2024 11:23am
ui-next ✅ Ready (Inspect) Visit Preview Aug 21, 2024 11:23am

@JunichiSugiura JunichiSugiura mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JunichiSugiura