Skip CreateSession if no policy is provided #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
6b0e615 to
4512e3c
Compare
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
4512e3c to
7a106e7
Compare
JunichiSugiura
force-pushed
the
fix(keychain)/no-policy
branch
from
7a106e7 to
674dd38
Compare
broody
reviewed
Aug 20, 2024
| if (mode === LoginMode.Controller && policies.length > 0) { | ||
| await controller.approve(origin, expiresAt, policies); | ||
| } else { | ||
| await doLogin(usernameField.value, credentialId); |
There was a problem hiding this comment.
@JunichiSugiura I made small change here to make login require webauthn authentication if no policies. Otherwise ppl can log into others account, any txn will fail but just feels weird.
broody
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
===========================================
+ Coverage 19.35% 30.47% +11.12%
===========================================
Files 3 34 +31
Lines 31 6438 +6407
Branches 7 0 -7
===========================================
+ Hits 6 1962 +1956
- Misses 25 4476 +4451 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry #592